Re: Adding REPACK [concurrently]

Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:

> I've stumbled upon one more issue with this feature:
> CREATE TABLE t (i int PRIMARY KEY);
> REPACK (CONCURRENTLY) t;
>
> fails for me with sanitizers enabled and
> min_dynamic_shared_memory = '1GB'
> in postgresql.conf as below:
> 2026-04-12 13:23:02.000 UTC [2733633] LOG: statement: REPACK (CONCURRENTLY) t;
> repack.c:3373:15: runtime error: load of value 240, which is not a valid value for type '_Bool'
> #0 0x6441f7eba454 in start_repack_decoding_worker .../src/backend/commands/repack.c:3373
> #1 0x6441f7ebdaad in rebuild_relation .../src/backend/commands/repack.c:1010
> #2 0x6441f7ebe9a2 in cluster_rel .../src/backend/commands/repack.c:656
> #3 0x6441f7ebefea in process_single_relation .../src/backend/commands/repack.c:2359
> #4 0x6441f7ebf870 in ExecRepack .../src/backend/commands/repack.c:296
> #5 0x6441f886f20e in standard_ProcessUtility .../src/backend/tcop/utility.c:867

I could not reproduce the problem, but noticed that the field is not
initialized correctly. Please confirm that 0001 should fix that.

While working on it, I noticed that one field can be removed from
DecodingWorkerShared - 0002 removes that.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com