Re: appendBinaryStringInfo stuff

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: appendBinaryStringInfo stuff
Date: 2022-12-22 07:56:11
Message-ID: 1826407.1671695771@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> 22.57% postgres [.] escape_json

Hmm ... shouldn't we do something like

- appendStringInfoString(buf, "\\b");
+ appendStringInfoCharMacro(buf, '\\');
+ appendStringInfoCharMacro(buf, 'b');

and so on in that function? I'm not convinced that this one
hotspot justifies inlining appendStringInfoString everywhere.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-12-22 07:59:30 Re: Force streaming every change in logical decoding
Previous Message Drouvot, Bertrand 2022-12-22 07:50:34 Re: Minimal logical decoding on standbys