Re: A few warnings on Windows

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Wed, May 2, 2018 at 12:51 PM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> Perhaps that's what Peter E meant when he said "Windows could use some
>> manual adjustments in pg_config.h.win32 if anyone
>> cares"[1]. Should we just change this to 1? I'm going to go and test
>> that now. From googling sizeof(bool) am aware that ancient VC (before
>> 5.0 more than 20 years ago) had a header that defined bool as int, but
>> that seems irrelevant now, right?

> That compiles and runs the main checks (except tablespace which I
> suppress) cleanly for me and I assume it really is using
> stdbool.h this time. Hopefully plperl will be happier this way.

Pushed. I was slightly tempted to add a static assertion that
SIZEOF_BOOL == sizeof(bool), but there's not any obvious home
for such a thing, and it's probably just useless worrying anyway.

> Since my earlier test, a new entirely independent warning arrived with
> commit 41c912ca:

Ooops.

> Patch for that attached, too.

Pushed that too, thanks.

regards, tom lane