| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: CI slowdown due to PG_TEST_INITDB_EXTRA_OPTS |
| Date: | 2026-09-11 06:29:00 |
| Message-ID: | 1820B28B-6BDA-4815-AD0B-9BBAB1D3A820@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Nazir,
On Thu, Sep 10, 2026, Nazir Bilal Yavuz wrote:
> I would remove these steps; ccache don't differ between builds so
> there is no need to separate them. Other than that, LGTM.
Agreed. V3 removes the slice suffix from the ccache keys for both
Linux ASAN and MinGW.
For context, here are the timings from v3 run, without your
PG_TEST_SERVER_POSTGRES_OPTS patch.
Test world Complete job
Linux Autoconf 15:04 22:00
Linux Meson 32-bit 9:53 16:29
Linux ASAN slice 1/2 12:05 17:17
Linux ASAN slice 2/2 11:52 17:04
macOS 20:29 24:29
MinGW slice 1/2 8:51 19:13
MinGW slice 2/2 7:29 17:57
Visual Studio slice 1/2 13:01 16:48
Visual Studio slice 2/2 11:45 16:33
CompilerWarnings - 22:13
Further splitting any job would not help much.
Your patch is still much needed: it reduces the work itself.
Thank you for the review!
PFA v3.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Split-Linux-ASAN-and-MinGW-tests-across-runners.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-09-11 06:29:40 | Re: Review items for EXCEPT TABLE publication |
| Previous Message | Chao Li | 2026-09-11 06:04:10 | Re: Review items for EXCEPT TABLE publication |