| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Thomas Kellerer <shammat(at)gmx(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Is this a bug in pg_current_logfile() on Windows? |
| Date: | 2020-07-09 15:24:43 |
| Message-ID: | 1819939.1594308283@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 7/9/20 11:04 AM, Tom Lane wrote:
>> Therefore, we either should figure out how to get msys perl to do
>> that conversion (and remove it from our code altogether), or make the
>> conversions conditional on "is it msys perl?". I am not quite sure
>> if the existing tests "if $Config{osname} eq 'msys'" are a legitimate
>> implementation of that condition or not --- it seems like nominally
>> they are checking the OS not the Perl, but maybe it's close enough.
> If the reported OS is msys (it's a pseudo OS in effect) then the perl
> must be msys' perl. Even when called from msys, native perl reports the
> OS as MSWin32. So yes, close enough.
Cool, I'll go try changing all those conditions to use the msys test.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron | 2020-07-09 15:30:15 | Re: Clustering solution ? |
| Previous Message | Andrew Dunstan | 2020-07-09 15:22:43 | Re: Is this a bug in pg_current_logfile() on Windows? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-07-09 15:29:24 | Re: Postgres is not able to handle more than 4k tables!? |
| Previous Message | Andrew Dunstan | 2020-07-09 15:22:43 | Re: Is this a bug in pg_current_logfile() on Windows? |