Re: 15beta1 tab completion of extension versions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: 15beta1 tab completion of extension versions
Date: 2022-06-18 23:49:28
Message-ID: 1803867.1655596168@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> Extension version strings need to be quoted. Either double or single
> quotes will work. In released psql clients, tab completion offers double
> quoted suggestions:
> But commit 02b8048ba5 broke that, it now offers unquoted version strings
> which if used as offered then lead to syntax errors.

Ooops.

> The code change seems to have been intentional, but I don't think the
> behavior change was intended.

Given the comments about it, I'm sure I tested the behavior somewhere
along the line --- but I must not have done so with the final logic
of _complete_from_query.

> Putting pg_catalog.quote_ident back
> into Query_for_list_of_available_extension_versions* fixes it, but might
> not be the best way to fix it.

Yeah, that seems like the appropriate fix. Done, thanks for the report!

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-06-19 04:56:13 Re: 15beta1 tab completion of extension versions
Previous Message Jeff Janes 2022-06-18 18:09:48 15beta1 tab completion of extension versions