Re:Re: BUG #19070: issue with DETACH PARTITION CONCURRENTLY on a hash partition table

From: ocean_li_996 <ocean_li_996(at)163(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: "mohen(dot)lhy(at)alibaba-inc(dot)com" <mohen(dot)lhy(at)alibaba-inc(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, robertmhaas(at)gmail(dot)com
Subject: Re:Re: BUG #19070: issue with DETACH PARTITION CONCURRENTLY on a hash partition table
Date: 2025-10-10 17:14:49
Message-ID: 17a8f848.b7f6.199cf1e3b5e.Coremail.ocean_li_996@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi, Álvaro
At 2025-10-10 19:03:08, "Álvaro Herrera" <alvherre(at)kurilemu(dot)de> wrote:
>On 2025-Oct-10, ocean_li_996 wrote:
>
>> Since there has been no update in this thread for a few days, I
>> reached out to the primary committer for this functionality.
>

>Yes, this is buggy, and has been reported previously (#18371).

Thanks for your feedback. It seems I might have overlooked something.
At first, I assumed this was expected behavior, and after searching
the pgsql-hackers archives I did not find any related threads. I also
realize I haven’t checked pgsql-bugs.
>I'll fix
>it before the November minors, probably by removing the step of creating
>the constraints during detach. I think for stable branches I'll do that
>only for hash partitioning, to avoid breaking workloads that might
>depend on those constraints, but for branch master I'll do it for all
>partitioning strategies.

Based on the discussion in #18371 and my own investigation, I think the
proposed fix is appropriate. I’m attaching patches for both the stable
and master branches, FYI.

--
regards
Haiyang Li

Attachment Content-Type Size
0001_master_fix_detach_partition_concurrently_issue.patch application/octet-stream 5.5 KB
0001_stable_fix_detach_partition_concurrently_issue.patch application/octet-stream 4.0 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Geoghegan 2025-10-10 18:10:51 Re: BUG #19082: Failing assert in index scan
Previous Message Matthijs van der Vleuten 2025-10-10 17:09:01 Re: BUG #19082: Failing assert in index scan