| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Garen Torikian <gjtorikian(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Expand character set for ltree labels |
| Date: | 2023-01-06 15:59:14 |
| Message-ID: | 17991f98-efc4-0458-e3fd-50610bd501c1@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-10-05 We 18:05, Garen Torikian wrote:
> After digging into it, you are completely correct. I had to do a bit
> more reading to understand the relationships between UTF-8 and wchar,
> but ultimately the existing locale support works for my use case.
>
> Therefore I have updated the patch with three much smaller changes:
>
> * Support for `-` in addition to `_`
> * Expanding the limit to 512 chars (from the existing 256); again it's
> not uncommon for non-English strings to be much longer
> * Fixed the documentation to expand on what the ltree label's
> relationship to the DB locale is
>
Regardless of the punycode issue, allowing hyphens in ltree labels seems
quite reasonable. I haven't reviewed the patch yet, but if it's OK I
intend to commit it.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-01-06 16:21:28 | Re: Logical replication - schema change not invalidating the relation cache |
| Previous Message | Andrew Dunstan | 2023-01-06 15:18:55 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |