| From: | Manu <manuelreyesbravo(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Use an index scan in RemoveSubscriptionRel() |
| Date: | 2026-11-19 19:17:07 |
| Message-ID: | 179511582705.1083642.3119886126793452576@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Sawada-san,
On Thu, Nov 19, 2026 at 10:46 AM Masahiko Sawada
<sawada(dot)mshk(at)gmail(dot)com> wrote:
> I've attached the updated patch that includes the minor fix. I'm going
> to push it, barring any objections.
Thanks, v2 looks good to me. On the test: without the reordering,
the existing t/001_rep_changes.pl (SET PUBLICATION, line 491) and
t/024_add_drop_pub.pl (DROP PUBLICATION, line 62) already fail with
"btree index keys must be ordered by attribute", so the current
suite covers it, as does Chao's test. The check is a plain
elog(ERROR) in nbtpreprocesskeys.c, not an assertion, so it isn't
limited to assert-enabled builds.
Regards,
Manu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-11-19 19:32:42 | Re: Let OpenSSL auto-select DH parameters by default |
| Previous Message | Manu | 2026-11-19 19:08:57 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |