Re: REPACK enhancements

Hi Antonin,

On Wed, Nov 11, 2026 at 2:26 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:
> I don't really understand why 'xmax' should be involved. The original
> assertion checks exactly whether 'add_to_max' is the "current transaction" and
> I tried to disable it exactly when the function is called by REPACK (to replay
> data changes). However, 'xmax' can be invalid even in cases unrelated to
> REPACK (i.e. when doing "regular" UPDATE / DELETE). Thus what you propose
> makes the assertion a bit less useful.

You're right. I used xmax because the replay always gets here with
xmax invalid, so the code below never looks at the current
transaction. But a regular UPDATE or DELETE usually gets here the
same way, so for them the assertion would check nothing, and my
"keeps the old check" was wrong. Leaving it commented out, as in v05,
is fine with me.

Regards,
Manu