Re: Be strict when request to flush past end of WAL in WaitXLogInsertionsToFinish

On Wed, Oct 28, 2026, surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
> I looked at v7. 0001 looks right to me, [...]
> I have a few comments:

Thanks for the review. v8 attached; all four points are in 0001,
and 0002 is unchanged.

> 1. This can also happen during backups, not just with pg_switch_wal().

Right, the commit message now mentions the backup functions too.

> 2. The new comment only talks about the segment boundary, [...]

Taken, with your wording.

> 3. [...] CheckArchiveTimeout() says "If the returned pointer points
> exactly to a segment boundary, assume nothing happened."

I kept the check and extended the comment. Telling the two cases
apart would need a new API, which seems too much for a DEBUG1 message.

> 4. [...] adding Assert(EndPos <= reservedEnd) after the new
> computation [...]

Added.

Regards,
Paul Kim