| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Date: | 2010-12-27 18:07:03 |
| Message-ID: | 17925.1293473223@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, Dec 27, 2010 at 18:50, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> src/tools/pginclude/ already contains several scripts for this sort of
>> thing. Bruce runs them by hand occasionally, although I just found out
>> that he's evidently not run the does-each-header-compile-standalone
>> test in awhile. It would probably pay to automate these.
> Could this at some point be platform dependent? If so, could it be run
> on the buildfarm?
It's certainly possible that someone could use a C++ keyword in a
platform-specific, or feature-specific, part of an include file.
The current form of this script will only find problems in active
code; so running it on the buildfarm would be indicated if we want
to have real confidence that there are no problems.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-27 18:21:37 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Previous Message | Magnus Hagander | 2010-12-27 18:00:34 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-27 18:21:37 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Previous Message | Magnus Hagander | 2010-12-27 18:00:34 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |