| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ordering of header file inclusion |
| Date: | 2019-11-22 14:37:07 |
| Message-ID: | 17924.1574433427@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
vignesh C <vignesh21(at)gmail(dot)com> writes:
> After the inclusion they have define and further include based on #if
> defined. In few cases I had seen the include happens at the end of the
> file like in regcomp.c as there may be impact. I felt it is better not
> to change these files. Let me know your thoughts on the same.
I think the point of this patch series is just to make cosmetic
adjustments in places where people have randomly failed to maintain
alphabetic order of a consecutive group of #include's. Messing with
examples like the above is way out of scope, if you ask me --- it
entails more analysis, and more risk of breakage, than a purely
cosmetic goal is worth.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2019-11-22 15:32:22 | Re: SimpleLruTruncate() mutual exclusion |
| Previous Message | Alvaro Herrera | 2019-11-22 14:25:28 | Re: Attempt to consolidate reading of XLOG page |