Re: Progress reporting: a debug trace and a test framework

From: Manu <manuelreyesbravo(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Subject: Re: Progress reporting: a debug trace and a test framework
Date: 2026-10-06 01:29:09
Message-ID: 179125014996.802400.13042330481622402940@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

v4 attached, rebased over master.

While rebasing, the completeness check in 0006 flagged that commit
1378aa13430 ("Report per-index vacuum progress in pg_stat_progress_vacuum")
added PROGRESS_VACUUM_CURRENT_INDEX_RELID without it being described in the
spec that the test reads from progress.h. v4 classifies it -- it is the
OID of the index a worker is currently processing, so a free value.
Catching that kind of drift, a new counter that nothing describes or
tests, is what the check is for.

Nothing else changed since v3: the four bug fixes in 0001-0004 and the
PROGRESS_DEBUG trace in 0005 are the same.

Regards,
Manu

Attachment Content-Type Size
v4-0001-Fix-blocks_done-of-an-index-build-s-heap-scan-on-.patch text/x-patch 1.6 KB
v4-0002-Reset-the-index-build-progress-counters-for-every.patch text/x-patch 2.8 KB
v4-0003-Reset-VACUUM-s-dead-item-progress-counters-after-.patch text/x-patch 1.8 KB
v4-0004-Don-t-count-the-last-key-twice-in-a-parallel-GIN-.patch text/x-patch 1.6 KB
v4-0005-Add-PROGRESS_DEBUG-to-test-the-whole-sequence-of-.patch text/x-patch 55.2 KB
v4-0006-Check-the-documented-progress-phases-against-the-.patch text/x-patch 14.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message SungJun Jang 2026-10-06 01:40:59 Re: Remove invalid SS2/SS3 handling from EUC-KR routines
Previous Message David Rowley 2026-10-06 01:28:07 Re: stale comment in struct AlteredTableInfo