Hi Stefan,
Thank you for the thorough read -- your five points match the intent,
and I appreciate you checking the pitem != tried aliasing and the
plain-OR-only guard, since those are the two places it could have gone
wrong.
> guarding the inner loop with "if (!presult)" avoids starting the
> iterator after a successful first attempt and states the intent more
> directly.
Agreed, and it reads better. I measured it too and the saving does not
show in planning time, so I'd rather not reset the review with a new
version right before you mark it Ready for Committer. I have it ready
as a one-line change if you or the committer would prefer it in the
tree now; otherwise it is just as fine to fold in at commit time.
Thanks again for the review.
Regards,
Manu