Re: 42P16 error when dropping and adding column

Hi Fujii-san,

> Thanks! Attached is v2 patch, which includes your tests.
> While working with the v1 patch, I found that the following DDL failed
> [...] v2 fixes this regression introduced by v1.

I ran v2 through a differential of 32 ALTER TABLE cases on master
(a5447a2deac) and REL_18_STABLE, cassert builds, comparing each build
against unpatched master and REL_18: the 24 from the v1 review plus 8
around a separate named NOT NULL combined with ADD PRIMARY KEY.

v2 fixes the reported case and the seven other 42P16 forms in the set,
each with the expected catalog state (the primary key and an
auto-created NOT NULL). The regression you caught,

ALTER TABLE t ALTER COLUMN id DROP NOT NULL,
ADD PRIMARY KEY (id), ADD CONSTRAINT hoge NOT NULL id;

fails on v1 with "cannot create not-null constraint" and succeeds on
v2, as do the drop-column and partitioned variants of it.

No case in the set errors on v2 while succeeding on unpatched master or
REL_18. The scenarios where a primary key still cannot be added (ONLY
on an inheritance parent, a column that already holds a null row, a
redundant named NOT NULL on a column that already has one) error
identically on all three. master and REL_18 give the same result on
every case, and make check passes on both.

Thanks for folding in the tests.

Regards,
Manu