Re: pgsql: Fix multi-column range partitioning constraints.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix multi-column range partitioning constraints.
Date: 2017-05-13 19:46:04
Message-ID: 17902.1494704764@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Fix multi-column range partitioning constraints.

Newer gcc versions are not very happy with this:

partition.c: In function 'get_qual_from_partbound':
partition.c:1642:18: warning: 'partexprs_item_saved' may be used uninitialized in this function [-Wmaybe-uninitialized]
partexprs_item = partexprs_item_saved;
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
partition.c:1500:8: note: 'partexprs_item_saved' was declared here
*partexprs_item_saved;
^~~~~~~~~~~~~~~~~~~~

$ gcc -v
gcc version 6.3.1 20161221 (Red Hat 6.3.1-1) (GCC)

Please fix.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-05-13 21:22:14 pgsql: Fix race condition leading to hanging logical slot creation.
Previous Message Tom Lane 2017-05-13 19:14:45 pgsql: Redesign get_attstatsslot()/free_attstatsslot() for more safety