Re: Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG

From: Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Andrew Dunstan <amdunstan(at)gmail(dot)com>
Subject: Re: Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG
Date: 2026-09-03 10:00:00
Message-ID: 178842960036.1140.8272272790033693692.pgcf@coridan.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested

Patch looks good. Just a note: create_upper_paths_hook has no test coverage anywhere in the tree, at any call site — a pre-existing gap, not something to fix here. Could be a separate follow-up.
--
Regards,
Himanshu Upadhyaya
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Nidzwetzki 2026-09-03 10:03:54 Re: Many of psql's describe functions bloat cache / waste mem
Previous Message Chee Wooson 2026-09-03 09:56:25 Re: [PATCH v1 1/1] Avoid carrying self lock-only xmax to updated tuple