| From: | Soumen Kumar <soumenkumar9503(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Use WALReadFromBuffers in more places |
| Date: | 2026-08-31 18:09:26 |
| Message-ID: | 178819976626.1145.783386611280561013.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
So,the patch applied cleanly to master branch(basically,i cut a branch and applied the patch), builds without issues, and passes the regression tests.
Since,this was my first time reviewing a code in particular, learning from this how buffer-only reads bypass WALRead() and why closing the open segment file descriptor is required to avoid stale descriptors across WAL segment boundaries was a great insight into how WAL reading works.
overall,it looks good
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-08-31 18:14:03 | Re: REPACK (CONCURRENTLY) backend waits indefinitely when decoding worker fails to start |
| Previous Message | Matheus Alcantara | 2026-08-31 18:07:07 | Re: Enable partitionwise join for partition keys wrapped by RelabelType |