| From: | Stepan Filippov <stepan(dot)filippov(at)yandex(dot)ru> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: 028_pitr_timelines.pl might fail when cp interrupted and backup includes required segment |
| Date: | 2026-08-31 10:21:45 |
| Message-ID: | 178817170586.1143.9597198436299527603.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, failed
Hi!
This looks like a reasonable improvement.
However, i have some questions about realization.
1. In general case we use $$ to add pid to temp_path, whereas on windows we do not use this.
I believe, this can cause name collision, which is not great.
2. In documentation [1] we do not specify that archive command needs to be atomic. Furthermore, we use actual cp as an example.
This can lead to similar problems not only in tests.
Thank you!
[1] https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL
Best regards, Stepan Filippov.
The new status of this patch is: Waiting on Author
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-08-31 10:31:35 | Re: REPACK (CONCURRENTLY) backend waits indefinitely when decoding worker fails to start |
| Previous Message | Ewan Young | 2026-08-31 10:08:04 | Re: GRAPH_TABLE pattern WHERE clause is not coerced to boolean |