| From: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> |
| Subject: | Re: Move system identifier generation to a common helper |
| Date: | 2026-08-24 14:59:45 |
| Message-ID: | 178758358536.1145.1103226781156198059.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hello,
I have reviewed this patch and it looks good to me.
I have built and tested with both make and meson.
Running make check-world is OK and running with meson:
cd build
meson test -q --print-errorlogs
reports:
Ok: 356
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 35
Timeout: 0
There is no SQL compliance to check and I don't think documentation should be updated.
Regards
PF
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-08-24 15:06:48 | Re: Add bms_offset_members() function for bitshifting Bitmapsets |
| Previous Message | Ilia Evdokimov | 2026-08-24 13:54:13 | Re: Fix var_eq_const: sum selectivity of all matching MCV entries instead of stopping at first match |