Re: [PATCH] Add planner support function to two-argument regexp_like()

From: Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: shihao zhong <zhong950419(at)gmail(dot)com>
Subject: Re: [PATCH] Add planner support function to two-argument regexp_like()
Date: 2026-08-13 14:23:29
Message-ID: 178663100991.1096.14061735930335908485.pgcf@coridan.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested

I have checked that make installcheck-world does not report any issue: the new test case works as expected.

There is no change in SQL so I did not test SQL compliance. I don't think that documentation should be changed as this is an optimization change only.

Average execution time of make installcheck-world with patch is 748s.

Average execution time of make installcheck-world without patch is 749,6 s.

This patch review looks easy because there is little code change . However it's for more difficult to understand the context if you don't know what a planned support function is (that was my case).

I think this patch should be reviewed by a more experienced contributor with query planner skills.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2026-08-13 14:45:42 Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically
Previous Message Matthias van de Meent 2026-08-13 13:50:34 Re: Logical replication row filter loses unchanged toasted columns