| From: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Zizhuan Liu <44973863(at)qq(dot)com> |
| Subject: | Re: [PATCH] Doc: Mention OFF as an alias for EXPLAIN SERIALIZE NONE |
| Date: | 2026-08-01 15:09:51 |
| Message-ID: | 178559699133.863439.7214315376013518674.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
I have reviewed your documentation patch.
It looks good to me except that there is a missing space between 'NONE' and '(' in: "SERIALIZE NONE(or OFF),"
Include information on the cost of serializing the query's output data, that is converting it to text or binary format to send to the client. This can be a significant part of the time required for regular execution of the query, if the datatype output functions are expensive or if TOASTed values must be fetched from out-of-line storage. EXPLAIN's default behavior, SERIALIZE NONE(or OFF), does not perform these conversions. If SERIALIZE TEXT or SERIALIZE BINARY is specified, the appropriate conversions are performed, and the time spent doing so is measured (unless TIMING OFF is specified). If the BUFFERS option is also specified, then any buffer accesses involved in the conversions are counted too. In no case, however, will EXPLAIN actually send the resulting data to the client; hence network transmission costs cannot be investigated this way. Serialization may only be enabled when ANALYZE is also enabled. If SERIALIZE is written without an argument, TEXT is assumed.
Could you fix this ?
Thanks.
The new status of this patch is: Waiting on Author
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-08-01 15:59:46 | Re: RI fast path gets cross-type foreign keys wrong |
| Previous Message | Peter Geoghegan | 2026-08-01 15:01:52 | GiST multirange index scans can fail to return rows |