| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-portable shell code in pg_upgrade tap tests |
| Date: | 2018-07-20 14:25:47 |
| Message-ID: | 17833.1532096747@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> writes:
> I've discovered that in the branch REL_11_STABLE there is shell script
> src/bin/pg_upgrade/test.sh which doesn't work under Solaris 10.
> (it uses $(command) syntax with is not compatible with original
> Solaris /bin/sh)
OK ...
> It is quite easy to replace $() syntax with backticks. Backticks are
> not nestable and considered unsafe by modern shell scripting style
> guides, but they do work with older shells.
Please send a patch. Most of us do not have access to old shells
we could test this on. (The oldest machine I have, and it's old
enough to vote, does run that script ... I doubt very many other
developers have anything older.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-20 14:48:15 | Re: Fw: Windows 10 got stuck with PostgreSQL at starting up. Adding delay lets it avoid. |
| Previous Message | Victor Wagner | 2018-07-20 12:38:20 | Non-portable shell code in pg_upgrade tap tests |