Re: [PATCH] Allow CustomScan nodes to signal projection support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sven Klemm <sven(at)timescale(dot)com>
Subject: Re: [PATCH] Allow CustomScan nodes to signal projection support
Date: 2021-07-06 22:14:16
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Aleksander Alekseev <aleksander(at)timescale(dot)com> writes:
>> I named the flag CUSTOMPATH_SUPPORT_PROJECTION similar to the other
>> custom node flags, but this would revert the current logic

> This seems to be a typical Kobayashi Maru situation, i.e any choice is
> a bad one. I suggest keeping the patch as is and hoping that the
> developers of existing extensions read the release notes.

Yeah, I concur that's the least bad choice.

I got annoyed by the fact that the existing checks of CustomPath flags
had several randomly different styles for basically identical tests,
and this patch wanted to introduce yet another. I cleaned that up and
pushed this.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gilles Darold 2021-07-06 22:18:31 [PATCH][postgres_fdw] Add push down of CASE WHEN clauses
Previous Message Mark Dilger 2021-07-06 22:12:31 Re: visibility map corruption