Re: release note item

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: release note item
Date: 2012-05-21 16:19:27
Message-ID: 17815.1337617167@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Regarding the item:
> * Properly handle empty arrays returned by PL/Perl functions (Andrew
> Dunstan) DETAILS?

> This was a bug fix, not a feature, and in any case is due to Alex
> Hunsaker, not me.

I assume this is in reference to these commits:

Author: Andrew Dunstan <andrew(at)dunslane(dot)net>
Branch: REL9_1_STABLE Release: REL9_1_0 [22a55b3af] 2011-08-17 12:03:26 -0400

Properly handle empty arrays returned from plperl functions.

Bug reported by David Wheeler, fix by Alex Hunsaker.
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch master
# Changes to be committed:
# (use "git reset HEAD <file>..." to unstage)
#
# modified: src/pl/plperl/plperl.c
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
#
# autom4te.cache/
# configure.in~
# doc/src/sgml/ref/grant.sgml~
# src/backend/port/win32_latch.c~
# src/bin/psql/command.c~
# src/include/pg_config.h.win32~
# src/pl/plpython/plpython.c~
# src/tools/msvc/pgbison.bat~
# src/tools/msvc/pgbison.pl.bak
# src/tools/msvc/pgflex.bat~
# src/tools/msvc/pgflex.pl.bak
# src/tools/pgindent/README~
# src/tools/pgindent/pgindent.pl
# src/tools/pgindent/pgindent.pl~
# xxxxx
# yyyyyy

Author: Andrew Dunstan <andrew(at)dunslane(dot)net>
Branch: master [68c903a66] 2011-08-17 11:59:18 -0400

Properly handle empty arrays returned from plperl functions.

Bug reported by David Wheeler, fix by Alex Hunsaker.

git_changelog failed to merge them because of the different commit
messages, which is probably why Bruce thought it was a HEAD-only
commit. AFAICS we should just remove this item, since it was (or
should've been) documented already in 9.1 release notes.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2012-05-21 16:22:32 Re: Archiver not exiting upon crash
Previous Message Tom Lane 2012-05-21 15:57:09 Re: External Open Standards