| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Rework option set of vacuumlo |
| Date: | 2018-08-28 21:08:25 |
| Message-ID: | 17758.1535490505@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
I wrote:
> Digging, this is because the "make check" processing isn't actually
> installing oid2name (resp. vacuumlo) into the temp installation tree :-(.
>
> I don't think this is the fault of your tests, exactly --- there's
> something wrong in the existing make rules. I'm not sure what though.
> EXTRA_INSTALL should be getting set, according to pgxs.mk:
> temp-install: EXTRA_INSTALL+=$(subdir)
> but it evidently isn't.
Oh! The reason why not is that that line is inside "ifdef REGRESS",
and these subdirectories have no REGRESS tests. So we should move
that out to where it will apply regardless of that. Will fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-28 21:26:28 | pgsql: Include contrib modules in the temp installation even without RE |
| Previous Message | Tom Lane | 2018-08-28 20:39:10 | Re: pgsql: Rework option set of vacuumlo |