| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Roland Volkmann <roland(dot)volkmann(at)gmx(dot)de>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Charset WIN1252 |
| Date: | 2004-12-05 19:14:20 |
| Message-ID: | 17743.1102274060@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> OK, good summary. Shame we missed this for 8.0. I am sure we will do
> better next time.. Wow, you had been working on this since November
> 2nd. Shame it didn't make it. Sorry again.
A minimum requirement for accepting an updated patch is that it should
hit all the same places where "grep" finds references to the other
WIN125? encodings. Aside from the missed lookup-table update that I
complained of, I observe that the patch failed to update documentation
or test cases; neither of those omissions is acceptable.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Hallgren | 2004-12-05 19:21:36 | Need access to a Linux box |
| Previous Message | Andreas Pflug | 2004-12-05 12:05:52 | Re: Error: column "nsptablespace" does not exist |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-12-05 19:33:18 | Re: patch contrib/pgcrypto for win32 (2) |
| Previous Message | Andrew Dunstan | 2004-12-05 19:06:05 | Re: patch contrib/pgcrypto for win32 (2) |