| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Generate fmgr prototypes automatically |
| Date: | 2017-01-17 19:35:28 |
| Message-ID: | 1771.1484681728@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Generate fmgr prototypes automatically
BTW, now that I've looked through this patch ... why does it add
+#include "nodes/nodes.h"
+#include "nodes/pg_list.h"
to utils/builtins.h? AFAICS that shouldn't be necessary, since
there are no declarations in builtins.h that weren't there before.
And seeing that this results in builtins.h being included in even more
places than before, surely we want to minimize that file's inclusion
footprint.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-17 19:46:53 | Re: pgsql: Generate fmgr prototypes automatically |
| Previous Message | Alvaro Herrera | 2017-01-17 19:33:45 | pgsql: Fix typo |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-17 19:46:53 | Re: pgsql: Generate fmgr prototypes automatically |
| Previous Message | Tom Lane | 2017-01-17 19:18:59 | Re: pgsql: Generate fmgr prototypes automatically |