Re: A couple of gripes about the gettext plurals patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: A couple of gripes about the gettext plurals patch
Date: 2009-05-27 20:47:18
Message-ID: 17698.1243457238@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On Tuesday 26 May 2009 21:05:29 Tom Lane wrote:
>> I experimented with this and found that indeed both format strings are
>> checked ... if you have a reasonably recent libintl.h AND you have
>> specified --enable-nls. Otherwise it all goes to heck, apparently
>> because the compiler doesn't try to look through our substitute
>> definition
>>
>> #define ngettext(s,p,n) ((n) == 1 ? (s) : (p))

> I can't reproduce that. Do you have a concrete example? Different compiler
> versions, perhaps?

Hmm, I was experimenting with Fedora 10's gcc (4.3.2) ... what are you
testing?

I don't have the test case anymore but will see if I can reconstruct it.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2009-05-27 20:49:42 Re: search_path vs extensions
Previous Message Kevin Grittner 2009-05-27 20:34:36 User-facing aspects of serializable transactions