Re: psql client does not handle WSAEWOULDBLOCK on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ning <ning94803(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: psql client does not handle WSAEWOULDBLOCK on Windows
Date: 2025-10-05 19:14:44
Message-ID: 1768846.1759691684@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Also, what about pqsecure_raw_write() in pqsecure_open_gss()?
>> Shouldn't the same check apply?

> Yeah, I think we pretty much need to use SOCK_ERRNO, SOCK_ERRNO_SET,
> and SOCK_STRERROR (if relevant) throughout fe-secure-gssapi.c.

Since nothing seems to be happening here, I took another look and
decided that the required changes are really pretty straightforward.
fe-secure-gssapi.c doesn't contain any strerror calls, and its
touches of errno all appear to relate to socket errors, so we can
just change them all. As attached.

> Like you, I'm not really in a position to test this on Windows ...

I'm still not, but it's straightforward enough that I'm willing to
push on my own authority. I'll just put this up for long enough
to make sure that the cfbot is happy with it --- though I think
it's not building with GSSAPI on Windows, so that may prove little.

regards, tom lane

Attachment Content-Type Size
v2-0001-Use-SOCK_ERRNO-_SET-in-fe-secure-gssapi.c.patch text/x-diff 5.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-10-05 22:19:49 Re: Refactoring: Use soft error reporting for *_opt_error functions
Previous Message Tom Lane 2025-10-05 18:26:16 Re: psql: Count all table footer lines in pager setup