| From: | Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | Andrew Kim <tenistarkim(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Proposal for enabling auto-vectorization for checksum calculations |
| Date: | 2026-01-16 04:22:10 |
| Message-ID: | 1768537330.605656780@fmail1.qdit |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thursday, January 15, 2026 17:35 +07, John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>External programs are probably doing some one-off task, so I don't see
>a reason to work harder.
Well, yeah, I agree. I was mostly thinking about some backup tools that
could use pg_checksum_page. With a quick search I've found only [1], though.
>> Also, not moving all those checksum files to src/port saves us from
>> thinking about problems with meson and current external programs,
>> but, I think, that after hardware checks are refactored, we could
>> revisit the question of moving checksum[_impl].h/.c to src/port.
>
>Refactoring the hardware checks is not going to make those two
>problems go away, and I don't understand why you want to move anything
>to begin with.
Yeah, moving checksum files to src/port introduces those two problems,
and I don't think there is any serious upside in doing this. There was some
discussion about it during v5 and v6, but as of v10, this is not needed.
[1] - https://github.com/ossc-db/pg_rman
--
Regards,
Oleg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-01-16 04:22:43 | Re: using index to speedup add not null constraints to a table |
| Previous Message | Tom Lane | 2026-01-16 04:01:19 | Re: [PATCH] pl: fix can not build free-thread for plpython extension like 3.14t |