Re: New to_timestamp implementation is pretty strict

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New to_timestamp implementation is pretty strict
Date: 2008-12-01 14:52:21
Message-ID: 17683.1228143141@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"David E. Wheeler" <david(at)kineticode(dot)com> writes:
> On Dec 1, 2008, at 1:08 PM, Heikki Linnakangas wrote:
>> I think the end of string should be treated like a field separator,
>> colon in this example, and we should accept both of the above.
>> Opinions?

> I'm generally in favor of being generous in the input one can accept,
> but in this case it seems ambiguous to me. Is that supposed to be :30
> or :03? There's no way to tell.

But notice that we are allowing a single digit for the hour and minute
fields. It's inconsistent that the last field works differently.
(And it is that it's the last field, not that it's SS --- try minutes
as the last field.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2008-12-01 14:55:12 Re: New to_timestamp implementation is pretty strict
Previous Message Magnus Hagander 2008-12-01 14:49:38 Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new