Re: amcheck: support for GiST

From: Miłosz Bieniek <bieniek(dot)milosz(at)proton(dot)me>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Subject: Re: amcheck: support for GiST
Date: 2025-12-09 18:54:57
Message-ID: 176530649782.1475506.6134844446558550683.pgcf@coridan.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

Hi,
Together with Sergey we did a review and found a few things that need fixing:

- `contrib/amcheck/amcheck--1.5--1.6.sql:14` - missing space after comma
- `verify_gist.c` should be the second entry in meson.build, not at the end
- Some function arguments like `(GistCheckState * check_state, GistScanItem * stack)` have extra spaces after the `*` - should be `(GistCheckState *check_state, GistScanItem *stack)`
- Missing `#include "access/itup.h"` in `verify_common.h`
- Missing test file `007verify_gist_.pl` (not sure if should be created)
- `contrib/amcheck/sql/check_gist.sql` - missing cleanup statement `DROP TABLE toast_bug;`

Let us know if you need any clarification on these points!

- Miłosz and Sergey

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-12-09 19:10:24 Re: [PATCH] VACUUM: avoid pre-creation transactions holding back cleanup of newly created relations
Previous Message Antonin Houska 2025-12-09 18:52:37 Re: Adding REPACK [concurrently]