| From: | Mahmoud Ayman <mahmoud(dot)ayman(dot)fcai(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: gen_guc_tables.pl: Validate required GUC fields before code generation |
| Date: | 2025-11-18 19:33:47 |
| Message-ID: | 176349442723.1015.11904064248451731131.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
I tested patch v2 on top of current master.
- The patch applies cleanly.
- Full build and regression tests pass (“All 231 tests passed.”).
- I tested the validation by removing the `max` field from an int GUC
(archive_timeout). The script now reports a clear error pointing to the
exact line and missing field, instead of Perl “uninitialized value” warnings.
- Verified that the generated guc_tables.c output is unchanged.
- The added validation code is small and straightforward, and integrates
cleanly into the existing script.
Everything works as described.
I think this patch is ready for committer.
Reviewed-by: Mahmoud Ayman
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-11-18 19:37:40 | Re: Performance issues with parallelism and LIMIT |
| Previous Message | Tom Lane | 2025-11-18 19:16:54 | Re: Use merge-based matching for MCVs in eqjoinsel |