Re: Include extension path on pg_available_extensions

From: Rohit Prasad <rohit(dot)prasad(at)arm(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Subject: Re: Include extension path on pg_available_extensions
Date: 2025-11-11 02:06:14
Message-ID: 176282677490.2081919.14769189141245328542.pgcf@coridan.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

I am just getting started in the Postgres community (this is my first code review). So please excuse me if I have missed something (in terms of process etc).
I reviewed your proposed code changes in the attached patch file and they look good to me. I have some minor comments:

1. In src/test/modules/test_extensions/t/001_extension_control_path.pl, it would be nice if you could add a test that validates that the correct Extension location is displayed, if for example, the extension is being picked up from a customized location.
2. Nit-pick: In src/backend/commands/extension.c:get_available_versions_for_extension(), you could probably combine the following 2 lines into one to say "'comment' & 'location' stay the same.
/* comment stays the same */
/* location stays the same */

Hope this is helpful.

Thanks,
-Rohit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-11-11 02:40:38 Re: Suggestion to add --continue-client-on-abort option to pgbench
Previous Message Michael Paquier 2025-11-11 02:03:22 Re: [PATCH] libpq: Wrap out-of-memory error messages with libpq_gettext()