Re: Segfault when creating partition with a primary key and sql_drop trigger exists

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marco Slot <marco(at)citusdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Onder Kalaci <onder(at)citusdata(dot)com>
Subject: Re: Segfault when creating partition with a primary key and sql_drop trigger exists
Date: 2018-10-08 09:25:13
Message-ID: 175fc986-f024-b048-98a9-94a563bad550@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On 10/6/18 7:50 PM, Alvaro Herrera wrote:
> here's my proposed patch.

There is an incorrect assert condition within
EventTriggerCollectAlterTableSubcmd(). Maybe it should be like this?

- Assert(OidIsValid(currentEventTriggerState->currentCommand));
+ Assert(currentEventTriggerState->currentCommand);

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-10-08 09:30:09 Re: Procedure calls are not tracked in pg_stat_user_functions / track_functions
Previous Message Michael Paquier 2018-10-08 09:14:51 Re: out-of-order XID insertion in KnownAssignedXids