| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Rui DeSousa <rui(at)crazybean(dot)net>, Torsten Zuehlsdorff <mailinglists(at)toco-domains(dot)de>, Keith Fiske <keith(at)omniti(dot)com>, Matteo Beccati <php(at)beccati(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Marko Tiikkaja <marko(at)joh(dot)to>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: [HACKERS] kqueue |
| Date: | 2020-01-20 16:55:13 |
| Message-ID: | 17596.1579539313@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> [ 0001-Add-kqueue-2-support-for-WaitEventSet-v13.patch ]
I haven't read this patch in any detail, but a couple quick notes:
* It needs to be rebased over the removal of pg_config.h.win32
--- it should be touching Solution.pm instead, I believe.
* I'm disturbed by the addition of a hunk to the supposedly
system-API-independent WaitEventSetWait() function. Is that
a generic bug fix? If not, can we either get rid of it, or
at least wrap it in "#ifdef WAIT_USE_KQUEUE" so that this
patch isn't inflicting a performance penalty on everyone else?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2020-01-20 18:01:16 | Increase psql's password buffer size |
| Previous Message | Tom Lane | 2020-01-20 16:44:20 | Re: [HACKERS] kqueue |