Re: FETCH FIRST clause PERCENT option

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Surafel Temesgen <surafel3000(at)gmail(dot)com>
Cc: Ryan Lambert <ryan(at)rustprooflabs(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: FETCH FIRST clause PERCENT option
Date: 2019-08-19 10:55:17
Message-ID: 1754c1e3713312d54d1ce71777f5b472@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-08-19 11:18, Surafel Temesgen wrote:
>
> [..]
>
> [percent-incremental-v7.patch]

Thanks.

Another little thing, not sure it's a bug:

limit interprets its argument by rounding up or down as one would
expect:

table onek limit 10.4; --> gives 10 rows
table onek limit 10.6; --> gives 11 rows

but FETCH count PERCENT does not do that; it rounds always up.

select * from (table onek limit 100) f fetch first 10.4 percent rows
only; --> gives 11 rows
select * from (table onek limit 100) f fetch first 10.6 percent rows
only; --> gives 11 rows

I see that it's documented in the .sgml to behave as it does, but it
seems wrong to me;
shouldn't that 10.4-percent-query yield 10 rows instead of 11?

thanks,

Erik Rijkers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message movead li 2019-08-19 10:57:03 Re: Rearranging ALTER TABLE to avoid multi-operations bugs
Previous Message Kyotaro Horiguchi 2019-08-19 09:59:59 Re: [HACKERS] WAL logging problem in 9.4.3?