Re: Foreign key isolation tests

From: Rustam ALLAKOV <rustamallakov(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Paul Jungwirth <pj(at)illuminatedcomputing(dot)com>
Subject: Re: Foreign key isolation tests
Date: 2025-07-15 00:33:30
Message-ID: 175253961008.2853453.6439482510563278651.pgcf@coridan.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed

Hi Paul,
Thank you for your prompt reply.

> I have the same --enable-* options.
> But does TESTNAME actually restrict your run to just those three?
> It doesn't for me.

It does not for us either. We somehow overlooked, sorry. It will run all the
118 tests specified at isolation_schedule file.

> As far as I know there is no way to run selected isolation tests,
> other than editing the isolation_schedule file

Thank you for explaining this, indeed modifying isolation_schedule file
does the trick on testing single spec only.

> Is there documentation saying that it should do something?
No there is none. TESTNAME variable was suggested by Claude 4.0 Sonnet.

We have rerun again 'make world' and 'make check-world' with your current
changes, all tests are passing. Thank you for all your clarifications!
We believe these are ready for committer.

Kindest regards.

The new status of this patch is: Ready for Committer

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-07-15 00:55:54 Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Previous Message Tomas Vondra 2025-07-15 00:30:10 Re: AIO v2.5