Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows
Date: 2026-07-20 06:59:51
Message-ID: 174C770E-07C8-4400-AC80-A46BFC2B68DD@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jul 20, 2026, at 14:53, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 16.07.26 17:35, Paul A Jungwirth wrote:
>> On Wed, Jul 15, 2026 at 6:10 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>>
>>> Actually, when I received v4, I was also working on addressing Dean’s comments.
>>>
>>> I reviewed both v4 and v5, made some small adjustments, and here is v6:
>>>
>>> * For the create_policy doc change, I changed “check new row” to “check leftover rows”.
>>> * For the “SELECT rights” comment, I moved it into the block comment, because its position in v5 looked like a placeholder.
>>> * For the tests, v4 and v5 added the new cases in the MERGE section. I added the test in a more direct section.
>>> * For the tests, v4 and v5 granted INSERT privilege. V6 intentionally does not, because the test runs UPDATE/DELETE FOR PORTION OF, and INSERT privilege is not required for inserting leftover rows by design.
>> I took a look. These all seem like improvements to me.
>
> committed v6

Thanks for committing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-07-20 07:16:02 Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum
Previous Message Michael Paquier 2026-07-20 06:54:41 Re: Unexpected behavior after OOM errors