Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Date: 2010-09-26 00:52:39
Message-ID: 17499.1285462359@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

David Fetter <david(at)fetter(dot)org> writes:
> On Sat, Sep 25, 2010 at 11:04:28PM +0000, Tom Lane wrote:
>> The previous coding would decide that join removal was unsafe upon
>> finding a PlaceHolderVar that needed to be evaluated at the inner
>> rel and then used above the join. However, this fails to cover the
>> case of PlaceHolderVars that refer to both the inner rel and some
>> other rels. Per bug report from Andrus.

> The person who found it originally was Kirill (xitology) Simonov. He
> brought it up in IRC. :)

[ shrug ... ] I can only go by what I see in the bug report.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-09-26 04:22:58 pgsql: Fix some more bugs in git_changelog.
Previous Message Tom Lane 2010-09-26 00:51:04 pgsql: Minor improvements to git_changelog.