| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: additional contrib test suites |
| Date: | 2017-09-15 13:49:43 |
| Message-ID: | 17478.1505483383@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> So, we have one failure for chkpass on OpenBSD, because OpenBSD crypt()
> doesn't support the traditional two-character salt format.
> Option:
> - Use the resultmap features to make this an expected failure on OpenBSD.
> - Fix the module to work on OpenBSD. This would involve making a
> platform-specific modification to use whatever advanced salt format they
> want.
> - Replace the entire module with something that does not depend on crypt().
Or (4) drop the module's regression test again.
I'd go for (1) at least as a short-term answer. It's not clear to me
that it's worth the effort to do (2) or (3). Also, (3) probably breaks
backwards compatibility, if there is anyone out there actually using
this datatype.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-09-15 13:52:26 | Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction |
| Previous Message | Tomas Vondra | 2017-09-15 13:34:34 | Re: The case for removing replacement selection sort |