From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)stack(dot)net> |
Subject: | Re: contrib/ltree for 7.2 or 7.3 ? |
Date: | 2002-07-30 18:48:04 |
Message-ID: | 17477.1028054884@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Oleg Bartunov wrote:
>> One known issue: It'll not works with 64-bit OS. We'll certainly fix this
>> but will appreciate if somebody with access to 64-bit machine could help us.
Actually, it dumps core instantly on 32-bit machines too, if they are
pickier about alignment than Intel hardware is. You can't map
structures onto char[] arrays that start at odd byte offsets and not
expect trouble.
I also do not trust macros like this:
typedef struct {
int32 len;
uint16 numlevel;
char data[1];
} ltree;
#define LTREE_HDRSIZE ( sizeof(int32) + sizeof(uint16) )
because they take no account of the possibility of padding between fields.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2002-07-30 18:52:11 | Re: contrib/ltree for 7.2 or 7.3 ? |
Previous Message | Bruce Momjian | 2002-07-30 18:37:12 | Re: WAL file location |