Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query
Date: 2018-07-05 18:34:31
Message-ID: 1745121530815671@sas1-a3690af4eda2.qloud-c.yandex.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

> Currently pg_stat_statements_reset() and other stats reset functions like
> pg_stat_reset() can be executed only by superusers.
> But why did you allow pg_read_all_stats role to execute that function,
> by default? That change looks strange to me.
This is not behavior change, only fix documentation to current state. Commit https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=25fff40798fc4ac11a241bfd9ab0c45c085e2212 creates 1.5 version and grant execute to pg_read_all_stats

Backpatch proposal was started in separate thread https://www.postgresql.org/message-id/CAJrrPGcim%3DQ-7ewhuKr1n3mkeELySC-QeVHGZJJYwaaKMSJRkg%40mail.gmail.com

regards, Sergei

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-07-05 19:36:19 Re: mxid_age() and age(xid) appear undocumented
Previous Message Alvaro Herrera 2018-07-05 18:22:32 Re: pgsql: Fix "base" snapshot handling in logical decoding