| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Boxuan Zhai <bxzhai2010(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, heikki(dot)linnakangas(at)enterprisedb(dot)com |
| Subject: | Re: gSoC - ADD MERGE COMMAND - code patch submission |
| Date: | 2010-07-10 16:45:58 |
| Message-ID: | 17432.1278780358@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Fetter <david(at)fetter(dot)org> writes:
> Please find enclosed a patch against git master as of
> 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but
> fails on make check.
There seem to be about four different comment styles used in this patch,
none of which match the project standard:
http://developer.postgresql.org/pgdocs/postgres/source-format.html
BTW, I notice that that page fails to mention anything about preferred
window width. I believe the project standard is to make things readable
in an 80-column window --- anyone have an objection to stating that
explicitly?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-07-10 17:03:13 | Re: gSoC - ADD MERGE COMMAND - code patch submission |
| Previous Message | David Fetter | 2010-07-10 16:26:38 | Re: gSoC - ADD MERGE COMMAND - code patch submission |