Re: pgsql: Do all accesses to shared buffer headers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Do all accesses to shared buffer headers
Date: 2005-10-13 04:11:54
Message-ID: 17415.1129176714@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Neil Conway <neilc(at)samurai(dot)com> writes:
> On Wed, 2005-12-10 at 18:54 -0400, Tom Lane wrote:
>> We do however have here a New Coding Rule that's good for all parts
>> of the backend: if you are accessing a spinlock-protected data structure
>> then you should be using a volatile-qualified pointer for it.

> I think this is worth documenting more clearly

BTW, forgot to reply to this part, but: have at it.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Neil Conway 2005-10-13 06:17:34 pgsql: Add a comment describing the requirement that pointers into
Previous Message Tom Lane 2005-10-13 03:49:47 Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-10-13 04:28:56 Re: [HACKERS] Darwin compile fixes
Previous Message Neil Conway 2005-10-13 04:06:24 Re: Minor point about contrib/xml2 functions "IMMUTABLE"