Re: pg_ctl/pg_rewind tests vs. slow AIX buildfarm members

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_ctl/pg_rewind tests vs. slow AIX buildfarm members
Date: 2015-10-13 13:04:26
Message-ID: 17414.1444741466@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Oct 13, 2015 at 7:41 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm not sure if this will completely fix our problems with "pg_ctl start"
>> related buildfarm failures on very slow critters. It does get rid of the
>> hard wired 5-second timeout, but the 60-second timeout could still be an
>> issue. I think Noah was considering a patch to allow that number to be
>> raised. I'd be in favor of letting pg_ctl accept a default timeout length
>> from an environment variable, and then the slower critters could be fixed
>> by adjusting their buildfarm configurations.

> Being able to pass that as a command-line parameter (master-only
> change) would be welcome as well IMO.

Huh? The --timeout parameter has always been there. I'm just expressing
an opinion that modifying all the makefiles and test scripts to pass
through a timeout setting would be too messy.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-10-13 13:17:14 Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Previous Message David G. Johnston 2015-10-13 12:53:07 Re: [PROPOSAL] DIAGNOSTICS <var> = SKIPPED_ROW_COUNT