From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Exposing PG_VERSION_NUM in pg_config |
Date: | 2015-03-25 18:50:44 |
Message-ID: | 17371.1427309444@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> writes:
> On 3/24/15 6:26 PM, Tom Lane wrote:
>> Hm. We're all agreed that there's a use case for exposing PG_VERSION_NUM
>> to the makefiles, but I did not hear one for adding it to pg_config; and
>> doing the former takes about two lines whereas adding a pg_config option
>> entails quite a lot of overhead (documentation, translatable help text,
>> yadda yadda). So I'm not in favor of doing the latter without a much
>> more solid case than has been made.
> Why else would you want the version number other than to do some kind of
> comparison?
The question is why, if we supply the version number in a make variable,
you would not just use that variable instead of having to do
"$(shell $(PG_CONFIG) --something)". The shell version adds new failure
modes, removes none, and has no redeeming social value that I can see.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2015-03-25 19:00:10 | Re: Exposing PG_VERSION_NUM in pg_config |
Previous Message | Jim Nasby | 2015-03-25 18:03:13 | Re: Exposing PG_VERSION_NUM in pg_config |