From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: Regression test CREATE USER/ROLE usage |
Date: | 2016-04-10 17:55:27 |
Message-ID: | 17335.1460310927@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> broken that way as rowsecurity.sql, which is (still) creating roles
>> named "alice" and "bob", but it's not acceptable like this.
> Attached is a patch to fix all of the role usage in rowsecurity.sql
> (I believe, feel free to let me know if there's anything else). In
> particular, all of the roles are changed to begin with 'regress_', and
> they are all now created with NOLOGIN.
+1 for the general idea, although there's something to be said for
using names like 'regress_alice' and 'regress_bob' in this context.
'regress_user1' and 'regress_user2' are awfully gray and same-y,
and therefore a bit error-prone IMO.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2016-04-10 18:21:01 | Re: Regression test CREATE USER/ROLE usage |
Previous Message | Stephen Frost | 2016-04-10 17:42:59 | Regression test CREATE USER/ROLE usage |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2016-04-10 18:21:01 | Re: Regression test CREATE USER/ROLE usage |
Previous Message | Stephen Frost | 2016-04-10 17:42:59 | Regression test CREATE USER/ROLE usage |